linux-kernel - Re: [PATCH] DTS: ARM: gta04: remove legacy spi-cs-high to make display work again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201218071255.GD26857@atomide.com>
Date:   Fri, 18 Dec 2020 09:12:55 +0200
From:   Tony Lindgren <tony@...mide.com>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Benoît Cousson <bcousson@...libre.com>,
        Rob Herring <robh+dt@...nel.org>, linux-omap@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        letux-kernel@...nphoenux.org,
        Andreas Kemnade <andreas@...nade.info>, stable@...r.kernel.org
Subject: Re: [PATCH] DTS: ARM: gta04: remove legacy spi-cs-high to make
 display work again

* H. Nikolaus Schaller <hns@...delico.com> [201212 11:59]:
> This reverts
> 
> commit f1f028ff89cb ("DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again")
> 
> which had to be intruduced after
> 
> commit 6953c57ab172 ("gpio: of: Handle SPI chipselect legacy bindings")
> 
> broke the GTA04 display. This contradicted the data sheet but was the only
> way to get it as an spi client operational again.
> 
> The panel data sheet defines the chip-select to be active low.
> 
> Now, with the arrival of
> 
> commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")
> 
> the logic of interaction between spi-cs-high and the gpio descriptor flags
> has been changed a second time, making the display broken again. So we have
> to remove the original fix which in retrospect was a workaround of a bug in
> the spi subsystem and not a feature of the panel or bug in the device tree.
> 
> With this fix the device tree is back in sync with the data sheet and
> spi subsystem code.

Thanks applying into fixes.

Tony