linux-kernel - RE: [PATCH] staging: most: video: fixed a parentheses coding style issue.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <934cbebcb57a49fd8761cc8b3aaffbfa@AcuMS.aculab.com>
Date:   Fri, 18 Dec 2020 10:38:35 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Joe Perches' <joe@...ches.com>,
        Daniel West <daniel.west.dev@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "mchehab+huawei@...nel.org" <mchehab+huawei@...nel.org>,
        "christian.gromm@...rochip.com" <christian.gromm@...rochip.com>,
        "masahiroy@...nel.org" <masahiroy@...nel.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] staging: most: video: fixed a parentheses coding style
 issue.

From: Joe Perches
> Sent: 18 December 2020 10:09
> On Fri, 2020-12-18 at 09:49 +0000, David Laight wrote:
> > From: Joe Perches
> > checkpatch probably shouldn't complain about lines that end in (
> > if they are function definitions.
> 
> Opinons vary.
> 
> Very few function declaration/definitions in the linux kernel use the
> one line per argument style (gnu indent -bfde)
> 
> type function(
> 	type argument1,
> 	type argument2,
> 	...
> 	)
> {
> 	...
> }
> 
> It probably shouldn't be encouraged.

The only excuse for anything like that is if there are comments for
each parameter that are used to generate the interface documentation.

Using that style for function calls just wastes vertical space.
At least that doesn't happen in the kernel.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)