lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Dec 2020 15:22:47 +0100 From: Krzysztof Kozlowski <krzk@...nel.org> To: Marek Szyprowski <m.szyprowski@...sung.com> Cc: Rob Herring <robh+dt@...nel.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Lee Jones <lee.jones@...aro.org>, Chanwoo Choi <cw00.choi@...sung.com>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org, Sylwester Nawrocki <snawrocki@...nel.org> Subject: Re: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type On Fri, Dec 18, 2020 at 02:25:39PM +0100, Marek Szyprowski wrote: > On 10.12.2020 22:29, Krzysztof Kozlowski wrote: > > Interrupt line can be configured on different hardware in different way, > > even inverted. Therefore driver should not enforce specific trigger > > type - edge falling - but instead rely on Devicetree to configure it. > > > > The Samsung PMIC drivers are used only on Devicetree boards. > > > > Additionally, the PMIC datasheets describe the interrupt line as active > > low with a requirement of acknowledge from the CPU therefore the edge > > falling is not correct. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org> > > Tested-by: Marek Szyprowski <m.szyprowski@...sung.com> > > It looks that this together with DTS change fixes RTC alarm failure that > I've observed from time to time on TM2e board! Great! I'll add this to the commit msg. Thanks for testing. Best regards, Krzysztof > > > --- > > > > This patch should wait till DTS changes are merged, as it relies on > > proper Devicetree. > > ---
Powered by blists - more mailing lists