lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Dec 2020 14:29:14 +0000 From: Dave Stevenson <dave.stevenson@...pberrypi.com> To: Maxime Ripard <maxime@...no.tech> Cc: Eric Anholt <eric@...olt.net>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Thomas Zimmermann <tzimmermann@...e.de>, Daniel Vetter <daniel.vetter@...el.com>, David Airlie <airlied@...ux.ie>, Jason Cooper <jason@...edaemon.net>, bcm-kernel-feedback-list@...adcom.com, linux-arm-kernel@...ts.infradead.org, Marc Zyngier <maz@...nel.org>, Linux Media Mailing List <linux-media@...r.kernel.org>, Hans Verkuil <hverkuil-cisco@...all.nl>, LKML <linux-kernel@...r.kernel.org>, Mauro Carvalho Chehab <mchehab@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, linux-rpi-kernel@...ts.infradead.org, DRI Development <dri-devel@...ts.freedesktop.org> Subject: Re: [PATCH 12/15] drm/vc4: hdmi: Don't register the CEC adapter if there's no interrupts On Thu, 10 Dec 2020 at 13:47, Maxime Ripard <maxime@...no.tech> wrote: > > We introduced the BCM2711 support to the vc4 HDMI controller with 5.10, > but this was lacking any of the interrupts of the CEC controller so we > have to deal with the backward compatibility. > > Do so by simply ignoring the CEC setup if the DT doesn't have the > interrupts property. > > Signed-off-by: Maxime Ripard <maxime@...no.tech> Reviewed-by: Dave Stevenson <dave.stevenson@...pberrypi.com> > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index 327638d93032..69217c68d3a4 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -1655,9 +1655,15 @@ static int vc4_hdmi_cec_init(struct vc4_hdmi *vc4_hdmi) > { > struct cec_connector_info conn_info; > struct platform_device *pdev = vc4_hdmi->pdev; > + struct device *dev = &pdev->dev; > u32 value; > int ret; > > + if (!of_find_property(dev->of_node, "interrupts", NULL)) { > + dev_warn(dev, "'interrupts' DT property is missing, no CEC\n"); > + return 0; > + } > + > vc4_hdmi->cec_adap = cec_allocate_adapter(&vc4_hdmi_cec_adap_ops, > vc4_hdmi, "vc4", > CEC_CAP_DEFAULTS | > -- > 2.28.0 >
Powered by blists - more mailing lists