lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Dec 2020 15:31:11 +0100 From: "Enrico Weigelt, metux IT consult" <info@...ux.net> To: linux-kernel@...r.kernel.org Cc: mark.rutland@....com, alexander.shishkin@...ux.intel.com, jolsa@...hat.com, namhyung@...nel.org, catalin.marinas@....com, will@...nel.org, msalter@...hat.com, jacquiot.aurelien@...il.com, gerg@...ux-m68k.org, geert@...ux-m68k.org, tsbogend@...ha.franken.de, James.Bottomley@...senPartnership.com, deller@....de, benh@...nel.crashing.org, paulus@...ba.org, ysato@...rs.sourceforge.jp, dalias@...c.org, davem@...emloft.net, tglx@...utronix.de, bp@...en8.de, x86@...nel.org, hpa@...or.com, linus.walleij@...aro.org, bgolaszewski@...libre.com, maz@...nel.org, tony@...mide.com, arnd@...db.de, linux-alpha@...r.kernel.org, linux-c6x-dev@...ux-c6x.org, linux-ia64@...r.kernel.org, linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-s390@...r.kernel.org, linux-sh@...r.kernel.org, sparclinux@...r.kernel.org, linux-gpio@...r.kernel.org, linux-omap@...r.kernel.org, linux-arch@...r.kernel.org Subject: [PATCH 12/23] arch: x86: drop misleading warning on spurious IRQ The warning in ack_bad_irq() is misleading in several ways: * the term "vector" isn't quite correct * the printing format isn't consistent across the archs: some print decimal, some hex, some hex w/o 0x prefix. * the printed linux irq isn't meaningful in all cases - we actually would want it to print the hw irq. Since all call sites already print out more detailed and correct information, we just don't need to duplicate this in each single arch. So just drop it. Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net> --- arch/x86/kernel/irq.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index c5dd50369e2f..5c66c44b6b60 100644 --- a/arch/x86/kernel/irq.c +++ b/arch/x86/kernel/irq.c @@ -36,9 +36,6 @@ atomic_t irq_err_count; */ void ack_bad_irq(unsigned int irq) { - if (printk_ratelimit()) - pr_err("unexpected IRQ trap at vector %02x\n", irq); - /* * Currently unexpected vectors happen only on SMP and APIC. * We _must_ ack these because every local APIC has only N -- 2.11.0
Powered by blists - more mailing lists