linux-kernel - Re: [PATCH] add pin memory method for checkout add restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <cff4fee2-af5a-c77c-c085-7a2aaa6c40ff@infradead.org>
Date:   Fri, 18 Dec 2020 08:59:26 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     hejingxian <hejingxian@...wei.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>
Cc:     Hushiyuan <hushiyuan@...wei.com>,
        "hewenliang (C)" <hewenliang4@...wei.com>
Subject: Re: [PATCH] add pin memory method for checkout add restore

Hi,

On 12/18/20 6:25 AM, hejingxian wrote:
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 26956c0..73af2f0 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -560,3 +560,10 @@ config RANDOM_TRUST_BOOTLOADER
>        booloader is trustworthy so it will be added to the kernel's entropy
>        pool. Otherwise, say N here so it will be regarded as device input that
>        only mixes the entropy pool.
> +
> +config PIN_MEMORY_DEV
> +       bool "/dev/pinmem character device"
> +       depends PIN_MEMORY

	depends on

> +       default n

Don't need default n, it's already the default.

> +       help
> +       pin memory driver

Better help text, please. Also, it should be indented by 2 (more) spaces.


thanks.
-- 
~Randy