linux-kernel - Re: [PATCH] mm/filemap: Fix warning: no previous prototype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201218095756.18d259ea243e434a8a90403a@linux-foundation.org>
Date:   Fri, 18 Dec 2020 09:57:56 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     Matthew Wilcox <willy@...radead.org>,
        Xiangyang Yu <yuxiangyang4@...wei.com>,
        Linux-MM <linux-mm@...ck.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/filemap: Fix warning: no previous prototype

On Fri, 18 Dec 2020 09:39:30 +0530 Souptick Joarder <jrdr.linux@...il.com> wrote:

> On Thu, Dec 17, 2020 at 7:53 AM Matthew Wilcox <willy@...radead.org> wrote:
> >
> > On Thu, Dec 17, 2020 at 10:03:11AM +0800, Xiangyang Yu wrote:
> > > Fixed the warning when building with warnings enabled (W=1),
> > > This function is only used in filemap.c, so mark this function
> > > with 'static'.
> >
> > Good grief, no.  Look at the git history before proposing a patch.
> 
> revert "mm/filemap: add static for function __add_to_page_cache_locked"
> Revert commit 3351b16af494 ("mm/filemap: add static for function
> __add_to_page_cache_locked") due to incompatibility with
> ALLOW_ERROR_INJECTION which result in build errors.
> 

How about we add a prototype for __add_to_page_cache_locked() to squash
the warning, along with a comment explaining what's going on?