linux-kernel - Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <EEFB7148-86B7-4761-BAB2-D35F29614A3E@fb.com>
Date:   Fri, 18 Dec 2020 18:57:29 +0000
From:   Nick Terrell <terrelln@...com>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>
CC:     David Sterba <dsterba@...e.cz>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Eric Biggers <ebiggers@...nel.org>,
        Nick Terrell <nickrterrell@...il.com>,
        "squashfs-devel@...ts.sourceforge.net" 
        <squashfs-devel@...ts.sourceforge.net>,
        Christoph Hellwig <hch@...radead.org>,
        Yann Collet <cyan@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-f2fs-devel@...ts.sourceforge.net" 
        <linux-f2fs-devel@...ts.sourceforge.net>,
        Petr Malat <oss@...at.biz>, "Chris Mason" <clm@...com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>,
        "Niket Agarwal" <niketa@...com>,
        Btrfs BTRFS <linux-btrfs@...r.kernel.org>,
        "Johannes Weiner" <jweiner@...com>
Subject: Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6



> On Dec 16, 2020, at 5:23 PM, Michał Mirosław <mirq-linux@...e.qmqm.pl> wrote:
> 
> On Wed, Dec 16, 2020 at 10:07:38PM +0000, Nick Terrell wrote:
> [...]
>> It is very large. If it helps, in the commit message I’ve provided this link [0],
>> which provides the diff between upstream zstd as-is and the imported zstd,
>> which has been modified by the automated tooling to work in the kernel.
>> [0] https://github.com/terrelln/linux/commit/ac2ee65dcb7318afe426ad08f6a844faf3aebb41
> 
> I looks like you could remove a bit more dead code by noting __GNUC__ >= 4
> (gcc-4.9 is currently the oldest supported [1]).

Yeah, that would certainly be possible. My goal was to remove the most egregiously
irrelevant code from the kernel, in addition to unused functions which would generate
-Wframe-larger-than compiler warnings. My tooling doesn’t have the logic to reason
about >= relationships yet. If it isn’t too hard to add, I may go ahead and do that,
otherwise I will leave it for future work. I view that as a “nice to have” instead of a
hard requirement, though let me know if you disagree.

Best,
Nick

> [1] Documentation/process/changes.rst
> 
> Best Regards
> Michał Mirosław