lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Dec 2020 22:37:28 +0200 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Daniel Scally <djrscally@...il.com> Cc: linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org, linux-media@...r.kernel.org, devel@...ica.org, rjw@...ysocki.net, lenb@...nel.org, gregkh@...uxfoundation.org, yong.zhi@...el.com, sakari.ailus@...ux.intel.com, bingbu.cao@...el.com, tian.shu.qiu@...el.com, mchehab@...nel.org, robert.moore@...el.com, erik.kaneda@...el.com, pmladek@...e.com, rostedt@...dmis.org, sergey.senozhatsky@...il.com, linux@...musvillemoes.dk, laurent.pinchart+renesas@...asonboard.com, jacopo+renesas@...ndi.org, kieran.bingham+renesas@...asonboard.com, linus.walleij@...aro.org, heikki.krogerus@...ux.intel.com, kitakar@...il.com, jorhand@...ux.microsoft.com Subject: Re: [PATCH v2 06/12] software_node: Add support for fwnode_graph*() family of functions On Thu, Dec 17, 2020 at 11:43:31PM +0000, Daniel Scally wrote: > From: Heikki Krogerus <heikki.krogerus@...ux.intel.com> > > This implements the remaining .graph_* callbacks in the > fwnode operations structure for the software nodes. That makes > the fwnode_graph*() functions available in the drivers also > when software nodes are used. > > The implementation tries to mimic the "OF graph" as much as > possible, but there is no support for the "reg" device > property. The ports will need to have the index in their > name which starts with "port@" (for example "port@0", "port@1", > ...) and endpoints will use the index of the software node > that is given to them during creation. The port nodes can > also be grouped under a specially named "ports" subnode, > just like in DT, if necessary. > > The remote-endpoints are reference properties under the > endpoint nodes that are named "remote-endpoint". ... > + while ((port = software_node_get_next_child(parent, old))) { > + if (!strncmp(to_swnode(port)->node->name, "port", 4)) > + return port; > + old = port; > + } Dunno if we need defines for port and its length here. ... > + ret = kstrtou32(swnode->parent->node->name + 5, 10, &endpoint->port); But here at least comment is needed what 5 means ('port@' I suppose). > + if (ret) > + return ret; -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists