lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Dec 2020 21:43:43 +0100 From: "Ahmed S. Darwish" <a.darwish@...utronix.de> To: "James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, Daniel Wagner <dwagner@...e.de>, Jason Yan <yanaijie@...wei.com>, John Garry <john.garry@...wei.com>, Artur Paszkiewicz <artur.paszkiewicz@...el.com>, Jack Wang <jinpu.wang@...ud.ionos.com> Cc: linux-scsi@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, "Sebastian A. Siewior" <bigeasy@...utronix.de>, "Ahmed S. Darwish" <a.darwish@...utronix.de> Subject: [PATCH 00/11] scsi: libsas: Remove in_interrupt() check Folks, In the discussion about preempt count consistency across kernel configurations: https://lkml.kernel.org/r/20200914204209.256266093@linutronix.de it was concluded that the usage of in_interrupt() and related context checks should be removed from non-core code. This includes memory allocation mode decisions (GFP_*). In the long run, usage of in_interrupt() and its siblings should be banned from driver code completely. This series addresses SCSI libsas. Basically, the function: => drivers/scsi/libsas/sas_init.c: struct asd_sas_event *sas_alloc_event(struct asd_sas_phy *phy) { ... gfp_t flags = in_interrupt() ? GFP_ATOMIC : GFP_KERNEL; event = kmem_cache_zalloc(sas_event_cache, flags); ... } is transformed so that callers explicitly pass the gfp_t memory allocation flags. Affected libsas clients are modified accordingly. The first six patches have "Fixes: " tags and address bugs the were noticed during the context analysis. Thanks! 8<-------------- Ahmed S. Darwish (11): Documentation: scsi: libsas: Remove notify_ha_event() scsi: libsas: Introduce a _gfp() variant of event notifiers scsi: mvsas: Pass gfp_t flags to libsas event notifiers scsi: isci: port: link down: Pass gfp_t flags scsi: isci: port: link up: Pass gfp_t flags scsi: isci: port: broadcast change: Pass gfp_t flags scsi: libsas: Pass gfp_t flags to event notifiers scsi: pm80xx: Pass gfp_t flags to libsas event notifiers scsi: aic94xx: Pass gfp_t flags to libsas event notifiers scsi: hisi_sas: Pass gfp_t flags to libsas event notifiers scsi: libsas: event notifiers: Remove non _gfp() variants Documentation/scsi/libsas.rst | 5 ++-- drivers/scsi/aic94xx/aic94xx_scb.c | 18 ++++++------ drivers/scsi/hisi_sas/hisi_sas.h | 3 +- drivers/scsi/hisi_sas/hisi_sas_main.c | 26 ++++++++++-------- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 5 ++-- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 5 ++-- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 5 ++-- drivers/scsi/isci/port.c | 14 ++++++---- drivers/scsi/libsas/sas_event.c | 21 ++++++++------ drivers/scsi/libsas/sas_init.c | 11 ++++---- drivers/scsi/libsas/sas_internal.h | 4 +-- drivers/scsi/mvsas/mv_sas.c | 22 +++++++-------- drivers/scsi/pm8001/pm8001_hwi.c | 38 +++++++++++++------------- drivers/scsi/pm8001/pm8001_sas.c | 8 +++--- drivers/scsi/pm8001/pm80xx_hwi.c | 30 ++++++++++---------- include/scsi/libsas.h | 4 +-- 16 files changed, 116 insertions(+), 103 deletions(-) base-commit: 2c85ebc57b3e1817b6ce1a6b703928e113a90442 -- 2.29.2
Powered by blists - more mailing lists