linux-kernel - Re: [PATCH] Bluetooth: btqcomsmd: Fix a resource leak in error handling paths in the probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <53063008-8797-4395-B9D1-9D56D2D0D54C@holtmann.org>
Date:   Fri, 18 Dec 2020 22:21:19 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     agross@...nel.org, bjorn.andersson@...aro.org,
        Johan Hedberg <johan.hedberg@...il.com>,
        MSM <linux-arm-msm@...r.kernel.org>,
        linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: btqcomsmd: Fix a resource leak in error
 handling paths in the probe function

Hi Christophe,

> Some resource should be released in the error handling path of the probe
> function, as already done in the remove function.
> 
> The remove function was fixed in commit 5052de8deff5 ("soc: qcom: smd:
> Transition client drivers from smd to rpmsg")
> 
> Fixes: 1511cc750c3d ("Bluetooth: Introduce Qualcomm WCNSS SMD based HCI driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> drivers/bluetooth/btqcomsmd.c | 27 +++++++++++++++++++--------
> 1 file changed, 19 insertions(+), 8 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel