linux-kernel - Re: [PATCH] Bluetooth: Pause service discovery for suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E127EABD-FBE2-49E3-910D-6BF922E94EFF@holtmann.org>
Date:   Fri, 18 Dec 2020 22:31:39 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
Cc:     linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        CrosBT Upstreaming <chromeos-bluetooth-upstreaming@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Johan Hedberg <johan.hedberg@...il.com>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>
Subject: Re: [PATCH] Bluetooth: Pause service discovery for suspend

Hi Abhishek,

> Just like MGMT_OP_START_DISCOVERY, we should reject
> MGMT_OP_START_SERVICE_DISCOVERY with MGMT_STATUS_BUSY when we are paused
> for suspend.
> 
> Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
> ---
> On ChromeOS, we started getting reports of scanning failing after
> resuming from suspend. The root cause was that Start Service Discovery
> was being called while discovery was supposed to be paused for suspend
> and it was screwing up some internal state. Adding this check
> immediately fixed it.
> 
> The fix was tested by doing the following:
> * Set Discovery Filter ({'transport': 'auto'})
> * Start Discovery
> * Suspend
> * Resume
> * Check the Discovering property
> 
> Without the fix, this test failed when checking the Discovering
> property above.
> 
> net/bluetooth/mgmt.c | 8 ++++++++
> 1 file changed, 8 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel