linux-kernel - Re: [PATCH net v3] net: mvpp2: Fix GoP port 3 Networking Complex Control configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPv3WKd-=ywD4E6VBgMmkrpEtEHDXjK0ix-cJc1UKnUHAPk_BQ@mail.gmail.com>
Date:   Fri, 18 Dec 2020 04:34:03 +0100
From:   Marcin Wojtas <mw@...ihalf.com>
To:     Stefan Chulski <stefanc@...vell.com>
Cc:     netdev <netdev@...r.kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        "David S. Miller" <davem@...emloft.net>, nadavh@...vell.com,
        Yan Markman <ymarkman@...vell.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Russell King <rmk+kernel@...linux.org.uk>,
        stable@...r.kernel.org
Subject: Re: [PATCH net v3] net: mvpp2: Fix GoP port 3 Networking Complex
 Control configurations

Hi Stefan,

czw., 17 gru 2020 o 13:40 <stefanc@...vell.com> napisał(a):
>
> From: Stefan Chulski <stefanc@...vell.com>
>
> During GoP port 2 Networking Complex Control mode of operation configurations,
> also GoP port 3 mode of operation was wrongly set.
> Patch removes these configurations.
> GENCONF_CTRL0_PORTX naming also fixed.
>
> Cc: stable@...r.kernel.org
> Fixes: f84bf386f395 ("net: mvpp2: initialize the GoP")
> Signed-off-by: Stefan Chulski <stefanc@...vell.com>
> ---
>
> Changes in v3:
> - Added cc stable@...r.kernel.org
> Changes in v2:
> - Added Fixes tag.
>
>  drivers/net/ethernet/marvell/mvpp2/mvpp2.h      | 6 +++---
>  drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 8 ++++----
>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
> index 6bd7e40..39c4e5c 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
> @@ -651,9 +651,9 @@
>  #define     GENCONF_PORT_CTRL1_EN(p)                   BIT(p)
>  #define     GENCONF_PORT_CTRL1_RESET(p)                        (BIT(p) << 28)
>  #define GENCONF_CTRL0                                  0x1120
> -#define     GENCONF_CTRL0_PORT0_RGMII                  BIT(0)
> -#define     GENCONF_CTRL0_PORT1_RGMII_MII              BIT(1)
> -#define     GENCONF_CTRL0_PORT1_RGMII                  BIT(2)
> +#define     GENCONF_CTRL0_PORT2_RGMII                  BIT(0)
> +#define     GENCONF_CTRL0_PORT3_RGMII_MII              BIT(1)
> +#define     GENCONF_CTRL0_PORT3_RGMII                  BIT(2)
>
>  /* Various constants */
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index d64dc12..d2b0506 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -1231,9 +1231,9 @@ static void mvpp22_gop_init_rgmii(struct mvpp2_port *port)
>
>         regmap_read(priv->sysctrl_base, GENCONF_CTRL0, &val);
>         if (port->gop_id == 2)
> -               val |= GENCONF_CTRL0_PORT0_RGMII | GENCONF_CTRL0_PORT1_RGMII;
> +               val |= GENCONF_CTRL0_PORT2_RGMII;
>         else if (port->gop_id == 3)
> -               val |= GENCONF_CTRL0_PORT1_RGMII_MII;
> +               val |= GENCONF_CTRL0_PORT3_RGMII_MII;
>         regmap_write(priv->sysctrl_base, GENCONF_CTRL0, val);
>  }
>
> @@ -1250,9 +1250,9 @@ static void mvpp22_gop_init_sgmii(struct mvpp2_port *port)
>         if (port->gop_id > 1) {
>                 regmap_read(priv->sysctrl_base, GENCONF_CTRL0, &val);
>                 if (port->gop_id == 2)
> -                       val &= ~GENCONF_CTRL0_PORT0_RGMII;
> +                       val &= ~GENCONF_CTRL0_PORT2_RGMII;
>                 else if (port->gop_id == 3)
> -                       val &= ~GENCONF_CTRL0_PORT1_RGMII_MII;
> +                       val &= ~GENCONF_CTRL0_PORT3_RGMII_MII;
>                 regmap_write(priv->sysctrl_base, GENCONF_CTRL0, val);
>         }
>  }
> --

I tested the patch and LGTM.

Acked-by: Marcin Wojtas <mw@...ihalf.com>

Thanks,
Marcin