lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Dec 2020 23:46:34 +0000 From: Daniel Scally <djrscally@...il.com> To: Laurent Pinchart <laurent.pinchart@...asonboard.com> Cc: linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org, linux-media@...r.kernel.org, devel@...ica.org, rjw@...ysocki.net, lenb@...nel.org, gregkh@...uxfoundation.org, yong.zhi@...el.com, sakari.ailus@...ux.intel.com, bingbu.cao@...el.com, tian.shu.qiu@...el.com, mchehab@...nel.org, robert.moore@...el.com, erik.kaneda@...el.com, pmladek@...e.com, rostedt@...dmis.org, sergey.senozhatsky@...il.com, andriy.shevchenko@...ux.intel.com, linux@...musvillemoes.dk, laurent.pinchart+renesas@...asonboard.com, jacopo+renesas@...ndi.org, kieran.bingham+renesas@...asonboard.com, linus.walleij@...aro.org, heikki.krogerus@...ux.intel.com, kitakar@...il.com, jorhand@...ux.microsoft.com Subject: Re: [PATCH v2 06/12] software_node: Add support for fwnode_graph*() family of functions On 18/12/2020 22:13, Daniel Scally wrote: >>> + break; >>> + } >>> + >>> + /* No more endpoints for that port, so stop passing old */ >>> + old = NULL; >> >> I wonder if you could drop the 'old' variable and use 'enpoint' in the >> call to software_node_get_next_child(). You could then drop these two >> lines. > > That won't work, because endpoint would at that point not be a child of > the port we're passing, and the function relies on it being one: > > if (!p || list_empty(&p->children) || > (c && list_is_last(&c->entry, &p->children))) { > fwnode_handle_put(child); > return NULL; > } > Wait, that's nonsense of course, because endpoint gets set to NULL when software_node_get_next_child() finds nothing - I'll double check but pretty sure you're right.
Powered by blists - more mailing lists