linux-kernel - Re: [PATCH] clk: vc5: Use "idt,voltage-microvolt" instead of "idt,voltage-microvolts"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVg7xaxMsY3jFgFrLQB=irVp5gxBC89TLVscBs2Y-rcUg@mail.gmail.com>
Date:   Sat, 19 Dec 2020 12:31:27 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Luca Ceresoli <luca@...aceresoli.net>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Adam Ford <aford173@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: vc5: Use "idt,voltage-microvolt" instead of "idt,voltage-microvolts"

Hi Luca,

On Fri, Dec 18, 2020 at 11:18 PM Luca Ceresoli <luca@...aceresoli.net> wrote:
> On 18/12/20 13:52, Geert Uytterhoeven wrote:
> > Commit 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to
> > yaml") accidentally changed "idt,voltage-microvolts" to
> > "idt,voltage-microvolt" in the DT bindings, while the driver still used
> > the former.
> >
> > Update the driver to match the bindings, as
> > Documentation/devicetree/bindings/property-units.txt actually recommends
> > using "microvolt".
> >
> > Fixes: 260249f929e81d3d ("clk: vc5: Enable addition output configurations of the Versaclock")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > ---
> > There are no upstream users yet, but they are planned for v5.12, so I
> > think this should be in v5.11-rc1.
> >
> > Thanks!
> > ---
> >  drivers/clk/clk-versaclock5.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c
> > index c90460e7ef2153fe..43db67337bc06824 100644
> > --- a/drivers/clk/clk-versaclock5.c
> > +++ b/drivers/clk/clk-versaclock5.c
> > @@ -739,8 +739,8 @@ static int vc5_update_power(struct device_node *np_output,
> >  {
> >       u32 value;
> >
> > -     if (!of_property_read_u32(np_output,
> > -                               "idt,voltage-microvolts", &value)) {
> > +     if (!of_property_read_u32(np_output, "idt,voltage-microvolt",
> > +                               &value)) {
>
> Reviewed-by: Luca Ceresoli <luca@...aceresoli.net>

Thanks!

> Now the example in the bindings needs the same fix. I guess you doing it
> in your "Miscellaneous fixes and improvements" v2 series, otherwise I
> can do that.

Yep, planned for v2.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds