linux-kernel - Re: [PATCH] mm/vmscan: DRY cleanup for do_try_to_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X91Vg1Mg1nPk/Bsx@chrisdown.name>
Date:   Sat, 19 Dec 2020 01:21:07 +0000
From:   Chris Down <chris@...isdown.name>
To:     Jacob Wen <jian.w.wen@...cle.com>
Cc:     Michal Hocko <mhocko@...e.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] mm/vmscan: DRY cleanup for do_try_to_free_pages()

Jacob Wen writes:
>set_task_reclaim_state() is a function with 3 lines of code of which 2 
>lines contain WARN_ON_ONCE.
>
>I am not comfortable with the current repetition.

Ok, but could you please go into _why_ others should feel that way too? There 
are equally also reasons to err on the side of leaving code as-is -- since we 
know it already works, and this code generally has pretty high inertia -- and 
avoid mutation of code without concrete description of the benefits.