linux-kernel - Re: [RFC PATCH] ptrace: make ptrace() fail if the tracee changed its pid unexpectedly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201219193313.GB9539@redhat.com>
Date:   Sat, 19 Dec 2020 20:33:14 +0100
From:   Oleg Nesterov <oleg@...hat.com>
To:     Pedro Alves <palves@...hat.com>
Cc:     "Eric W. Biederman" <ebiederm@...ssion.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Eugene Syromiatnikov <esyr@...hat.com>,
        Jan Kratochvil <jan.kratochvil@...hat.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Michael Kerrisk <mtk.manpages@...il.com>,
        Simon Marchi <simon.marchi@...icios.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] ptrace: make ptrace() fail if the tracee changed its
 pid unexpectedly

On 12/19, Pedro Alves wrote:
>
> BTW, the problem was discovered by Simon Marchi when he tried to write
> a GDB testcase for a multi-threaded exec scenario:

OOPS! Sorry Simon, yes I forgot to add reported-by. Andrew, or Eric, if
you take this patch, could you also add

	Reported-by: Simon Marchi <simon.marchi@...icios.com>

> I've went through GDB's code looking for potential issues with the change and whether
> it would affect GDBs already in the wild.  Tricky corner cases abound, but I think
> we're good.  Feel free to add my ack:
>
> Acked-by: Pedro Alves <palves@...hat.com>

Thanks!

Oleg.