linux-kernel - Re: [PATCH] signal: Don't init struct kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201220152535.k74foxjgejedslgx@wittgenstein>
Date:   Sun, 20 Dec 2020 16:25:35 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Leesoo Ahn <dev@...eel.net>
Cc:     linux-kernel@...r.kernel.org, Leesoo Ahn <lsahn@...eel.net>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Oleg Nesterov <oleg@...hat.com>, Jens Axboe <axboe@...nel.dk>,
        Peter Collingbourne <pcc@...gle.com>,
        Zhiqiang Liu <liuzhiqiang26@...wei.com>
Subject: Re: [PATCH] signal: Don't init struct kernel_siginfo fields to zero
 again

On Sun, Dec 20, 2020 at 04:45:54PM +0900, Leesoo Ahn wrote:
> clear_siginfo() is responsible for clearing struct kernel_siginfo object.
> It's obvious that manually initializing those fields is needless as
> a commit[1] explains why the function introduced and its guarantee that
> all bits in the struct are cleared after it.
> 
> [1]: commit 8c5dbf2ae00b ("signal: Introduce clear_siginfo")
> 
> Signed-off-by: Leesoo Ahn <lsahn@...eel.net>
> ---

Acked-by: Christian Brauner <christian.brauner@...ntu.com>

I have a __user annotation fix in my tree from Jann that I plan to send
soon so I'll just stick this on top of it if noone minds.

Christian