linux-kernel - Re: [PATCH] epoll: fix compat syscall wire up of epoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTSeKfSouk7SV0cfuZ122J3fAc_ddy_a9unyCRq4F7f6+pw@mail.gmail.com>
Date:   Sun, 20 Dec 2020 13:22:06 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Heiko Carstens <hca@...ux.ibm.com>
Cc:     Arnd Bergmann <arnd@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Arnd Bergmann <arnd@...db.de>,
        Matthew Wilcox <willy@...radead.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] epoll: fix compat syscall wire up of epoll_pwait2

On Sun, Dec 20, 2020 at 6:43 AM Arnd Bergmann <arnd@...nel.org> wrote:
>
> On Sun, Dec 20, 2020 at 11:00 AM Heiko Carstens <hca@...ux.ibm.com> wrote:
> >
> > Commit b0a0c2615f6f ("epoll: wire up syscall epoll_pwait2") wired up
> > the 64 bit syscall instead of the compat variant in a couple of places.
> >
> > Cc: Willem de Bruijn <willemb@...gle.com>
> > Cc: Al Viro <viro@...iv.linux.org.uk>
> > Cc: Arnd Bergmann <arnd@...db.de>
> > Cc: Matthew Wilcox (Oracle) <willy@...radead.org>
> > Cc: Catalin Marinas <catalin.marinas@....com>
> > Cc: Will Deacon <will@...nel.org>
> > Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> > Cc: Vasily Gorbik <gor@...ux.ibm.com>
> > Cc: Christian Borntraeger <borntraeger@...ibm.com>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Fixes: b0a0c2615f6f ("epoll: wire up syscall epoll_pwait2")
> > Signed-off-by: Heiko Carstens <hca@...ux.ibm.com>
> > ---
> >  arch/arm64/include/asm/unistd32.h         | 2 +-
> >  arch/mips/kernel/syscalls/syscall_n32.tbl | 2 +-
> >  arch/s390/kernel/syscalls/syscall.tbl     | 2 +-
> >  arch/sparc/kernel/syscalls/syscall.tbl    | 2 +-
> >  4 files changed, 4 insertions(+), 4 deletions(-)
>
> I double-checked all the entries to make sure you caught all
> the missing ones, looks good.
>
> Acked-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Willem de Bruijn <willemb@...gle.com>

Thanks a lot. I also arrived at the same list after comparing to
epoll_pwait and signalfd (for sigset) and ppoll_time64 (for timespec64).

Slightly tangential, it's not immediately clear to me why in
arch/x86/entry/syscalls/syscall_32.tbl epoll_pwait does not need a
compat entry, unlike on other architectures and unlike signalfd.