linux-kernel - Re: [PATCH 1/2] checkpatch: kconfig: replace '---help---' with 'help'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f5c18acb8bac6f2d8c24e50eabc0f163c062475.camel@perches.com>
Date:   Sun, 20 Dec 2020 11:02:15 -0800
From:   Joe Perches <joe@...ches.com>
To:     Nicolai Fischer <nicolai.fischer@....de>,
        linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     apw@...onical.com, johannes.czekay@....de,
        linux-kernel@...cs.fau.de
Subject: Re: [PATCH 1/2] checkpatch: kconfig: replace '---help---' with
 'help'

On Mon, 2020-12-14 at 11:23 +0100, Nicolai Fischer wrote:
> All '---help---' lines have been replaced by just 'help'.
> Therefore it is no longer necessary to include '---' in the regex.
> 
> Signed-off-by: Nicolai Fischer <nicolai.fischer@....de>
> Co-developed-by: Johannes Czekay <johannes.czekay@....de>
> Signed-off-by: Johannes Czekay <johannes.czekay@....de>

Acked-by: Joe Perches <joe@...ches.com>

> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 52f467fd32f9..5cd98f2b75f6 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3323,7 +3323,7 @@ sub process {
>  
> 
>  				if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|prompt)\s*["']/) {
>  					$is_start = 1;
> -				} elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) {
> +				} elsif ($lines[$ln - 1] =~ /^\+\s*help$/) {
>  					$length = -1;
>  				}
>  
>