linux-kernel - RE: [PATCH] block: aoe: replace use of __constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d708db73308747feb0484287a09c443e@AcuMS.aculab.com>
Date:   Sun, 20 Dec 2020 19:35:54 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Amey Narkhede' <ameynarkhede03@...il.com>,
        "justin@...aid.com" <justin@...aid.com>
CC:     "axboe@...nel.dk" <axboe@...nel.dk>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] block: aoe: replace use of __constant_htons to htons

From: Amey Narkhede
> Sent: 20 December 2020 16:46
> 
> The macro htons expands to __swab16 which has special
> case for constants in little endian case. In big
> endian case both __constant_htons and htons macros
> expand to the same code. So, replace __constant_htons
> with htons to get rid of the definition of __constant_htons
> completely.
> 
...
>  static struct packet_type aoe_pt __read_mostly = {
> -	.type = __constant_htons(ETH_P_AOE),
> +	.type = htons(ETH_P_AOE),
>  	.func = aoenet_rcv,

Does this cause grief if someone is doing a COMPILE_TEST on LE?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)