linux-kernel - Re: [PATCH v2] regulators: bd718x7: Add enable times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c8457166ec3a69d7999f751fef54413c5c2ed5f.camel@fi.rohmeurope.com>
Date:   Mon, 21 Dec 2020 06:08:15 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        linux-power <linux-power@...rohmeurope.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "agx@...xcpu.org" <agx@...xcpu.org>
Subject: Re: [PATCH v2] regulators: bd718x7: Add enable times


On Fri, 2020-12-18 at 19:38 +0100, Guido Günther wrote:
> Use the typical startup times from the data sheet so boards get a
> reasonable default. Not setting any enable time can lead to board
> hangs
> when e.g. clocks are enabled too soon afterwards.
> 
> This fixes gpu power domain resume on the Librem 5.
> 
> Signed-off-by: Guido Günther <agx@...xcpu.org>
> 
> ---
> v2
> - As per review comment by Matti Vaittinen
>   
> https://lore.kernel.org/lkml/beba25e85db20649aa040fc0ae549895c9265f6f.camel@fi.rohmeurope.com/
>   Use defines instead of plain values
> - As per review comment by Mark Brown
>   https://lore.kernel.org/lkml/20201216130637.GC4861@sirena.org.uk/
>   Drop cover letter
> ---
>  drivers/regulator/bd718x7-regulator.c | 27 ++++++++++++++++++++++++
>  include/linux/mfd/rohm-bd718x7.h      | 30 

Thanks again Guido.
I might have preferred having the defines in bd718x7-regulator.c as
they are not likely to be used outside this file. That would have
strictly limited the change to regulator subsystem. Having them in the
header is still fine with me if it works for Mark & others. (I don't
think these defines need much of changes in the future).

Reviewed-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>


Best Regards
 Matti Vaittinen