linux-kernel - drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable 'hpd' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 21 Dec 2020 14:55:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kuogee Hsieh <khsieh@...eaurora.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Rob Clark <robdclark@...omium.org>
Subject: drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable 'hpd'
 set but not used

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   467f8165a2b0e6accf3d0dd9c8089b1dbde29f7f
commit: c58eb1b54feefc3a47fab78addd14083bc941c44 drm/msm/dp: fix connect/disconnect handled at irq_hpd
date:   3 weeks ago
config: arm-randconfig-r035-20201220 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c58eb1b54feefc3a47fab78addd14083bc941c44
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout c58eb1b54feefc3a47fab78addd14083bc941c44
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/msm/dp/dp_display.c: In function 'dp_display_usbpd_attention_cb':
>> drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable 'hpd' set but not used [-Wunused-but-set-variable]
     496 |  struct dp_usbpd *hpd;
         |                   ^~~


vim +/hpd +496 drivers/gpu/drm/msm/dp/dp_display.c

c943b4948b5848f Chandan Uddaraju 2020-08-27  490  
c943b4948b5848f Chandan Uddaraju 2020-08-27  491  static int dp_display_usbpd_attention_cb(struct device *dev)
c943b4948b5848f Chandan Uddaraju 2020-08-27  492  {
c943b4948b5848f Chandan Uddaraju 2020-08-27  493  	int rc = 0;
26b8d66a399e625 Kuogee Hsieh     2020-11-03  494  	u32 sink_request;
c943b4948b5848f Chandan Uddaraju 2020-08-27  495  	struct dp_display_private *dp;
26b8d66a399e625 Kuogee Hsieh     2020-11-03 @496  	struct dp_usbpd *hpd;
c943b4948b5848f Chandan Uddaraju 2020-08-27  497  
c943b4948b5848f Chandan Uddaraju 2020-08-27  498  	if (!dev) {
c943b4948b5848f Chandan Uddaraju 2020-08-27  499  		DRM_ERROR("invalid dev\n");
c943b4948b5848f Chandan Uddaraju 2020-08-27  500  		return -EINVAL;
c943b4948b5848f Chandan Uddaraju 2020-08-27  501  	}
c943b4948b5848f Chandan Uddaraju 2020-08-27  502  
061eb621fc2780a Abhinav Kumar    2020-09-12  503  	dp = container_of(g_dp_display,
061eb621fc2780a Abhinav Kumar    2020-09-12  504  			struct dp_display_private, dp_display);
c943b4948b5848f Chandan Uddaraju 2020-08-27  505  	if (!dp) {
c943b4948b5848f Chandan Uddaraju 2020-08-27  506  		DRM_ERROR("no driver data found\n");
c943b4948b5848f Chandan Uddaraju 2020-08-27  507  		return -ENODEV;
c943b4948b5848f Chandan Uddaraju 2020-08-27  508  	}
c943b4948b5848f Chandan Uddaraju 2020-08-27  509  
26b8d66a399e625 Kuogee Hsieh     2020-11-03  510  	hpd = dp->usbpd;
26b8d66a399e625 Kuogee Hsieh     2020-11-03  511  
c943b4948b5848f Chandan Uddaraju 2020-08-27  512  	/* check for any test request issued by sink */
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  513  	rc = dp_link_process_request(dp->link);
26b8d66a399e625 Kuogee Hsieh     2020-11-03  514  	if (!rc) {
26b8d66a399e625 Kuogee Hsieh     2020-11-03  515  		sink_request = dp->link->sink_request;
c58eb1b54feefc3 Kuogee Hsieh     2020-11-18  516  		if (sink_request & DS_PORT_STATUS_CHANGED)
c58eb1b54feefc3 Kuogee Hsieh     2020-11-18  517  			rc = dp_display_handle_port_ststus_changed(dp);
c58eb1b54feefc3 Kuogee Hsieh     2020-11-18  518  		else
26b8d66a399e625 Kuogee Hsieh     2020-11-03  519  			rc = dp_display_handle_irq_hpd(dp);
26b8d66a399e625 Kuogee Hsieh     2020-11-03  520  	}
c943b4948b5848f Chandan Uddaraju 2020-08-27  521  
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  522  	return rc;
c943b4948b5848f Chandan Uddaraju 2020-08-27  523  }
c943b4948b5848f Chandan Uddaraju 2020-08-27  524  

:::::: The code at line 496 was first introduced by commit
:::::: 26b8d66a399e625f3aa2c02ccbab1bff2e00040c drm/msm/dp: promote irq_hpd handle to handle link training correctly

:::::: TO: Kuogee Hsieh <khsieh@...eaurora.org>
:::::: CC: Rob Clark <robdclark@...omium.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (40685 bytes)