linux-kernel - Re: [PATCH] bcache: Trivial fix to bdput

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4891349b-2136-eb8b-758d-f937b558b1c0@suse.de>
Date:   Mon, 21 Dec 2020 15:35:17 +0800
From:   Coly Li <colyli@...e.de>
To:     Yi Li <yili@...hong.com>
Cc:     yilikernel@...il.com, kent.overstreet@...il.com,
        linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcache: Trivial fix to bdput

On 12/21/20 11:17 AM, Yi Li wrote:
> Trivial fix to bdput.
> 
> Signed-off-by: Yi Li <yili@...hong.com>e

Hi Yi,

Indeed these two fixes are not that trivial. I suggest to describe more
detail about why your fixes are necessary and what problems are fixed by
your patches.


Thanks.

Coly Li


> ---
>  drivers/md/bcache/super.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index f7ad1e26b013..1756f6926098 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -2525,8 +2525,8 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr,
>  			else
>  				err = "device busy";
>  			mutex_unlock(&bch_register_lock);
> -			if (!IS_ERR(bdev))
> -				bdput(bdev);
> +			if (!IS_ERR(dev))
> +				bdput(dev);
>  			if (attr == &ksysfs_register_quiet)
>  				goto done;
>  		}
>