linux-kernel - Re: [PATCH 2/2] checkpatch: kconfig: add missing types to regex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d7cef4f-071d-0504-74df-bd944a11dd70@fau.de>
Date:   Mon, 21 Dec 2020 16:08:11 +0100
From:   Nicolai Fischer <nicolai.fischer@....de>
To:     Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org
Cc:     apw@...onical.com, johannes.czekay@....de,
        linux-kernel@...cs.fau.de
Subject: Re: [PATCH 2/2] checkpatch: kconfig: add missing types to regex


On Sun, 2020-12-20 at 20:16 +0100, Joe Perches wrote:
> On Mon, 2020-12-14 at 11:24 +0100, Nicolai Fischer wrote:
>> Kconfig parsing does not recognise all type attributes.
>> This adds the missing 'int', 'sting' and 'hex' types.
> []
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>> @@ -3321,7 +3321,7 @@ sub process {
>>  				next if ($f =~ /^-/);
>>  				last if (!$file && $f =~ /^\@\@/);
>>  
>>
>> -				if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|prompt)\s*["']/) {
>> +				if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|int|hex|string|prompt)\s*["']/) {
>>  					$is_start = 1;
>>  				} elsif ($lines[$ln - 1] =~ /^\+\s*help$/) {
>>  					$length = -1;
> 
> Another thing that could be done is to enforce the "extra 2 spaces"
> indent by capturing the whitespace before the help keyword:
> 
> 				} elsif ($lines[$ln - 1] =~ /^\+\s*help$/) {
> 
> could be
> 
> 				} elsif ($lines[$ln - 1] =~ /^\+(\s*)help\s*$/) {
> 
> with $1 used to validate the extra indent.
> 
> 


In case the indent does not match, should we display a new warning as in our previous patch?

On Tue, 2020-12-08 at 14:35 +0100, Nicolai Fischer wrote> +				WARN("CONFIG_DESCRIPTION",
> +					"help text is not indented 2 spaces more than the help keyword\n" . $herecurr);