linux-kernel - Re: [PATCH v5 2/3] spi: Add SPI_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcVDCL1VnUzmAmcDJ3deveXy-S8C4gaiKJGAts3V8FjSA@mail.gmail.com>
Date:   Mon, 21 Dec 2020 19:24:42 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
Cc:     linux-spi <linux-spi@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Bogdan, Dragos" <Dragos.Bogdan@...log.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v5 2/3] spi: Add SPI_NO_TX/RX support

On Mon, Dec 21, 2020 at 5:19 PM Ardelean, Alexandru
<alexandru.Ardelean@...log.com> wrote:
> > -----Original Message-----
> > From: Andy Shevchenko <andy.shevchenko@...il.com>
> > Sent: Monday, December 21, 2020 4:37 PM
> > On Mon, Dec 21, 2020 at 4:34 PM Andy Shevchenko
> > <andy.shevchenko@...il.com> wrote:

...

> > One nit, though...
> >
> > > > -               "setup: can not select dual and quad at the same time\n");
> > > > +               "setup: can not select any two of dual, quad and no-rx/tx "
> > > > +               "at the same time\n");
> >
> > Can we avoid splitting string literals which are assumed to be on one line when
> > printed?
>
> It ends up at about 96 cols, but it's within limits.
> The patch may have been written before the new 100 col-width limit.

JFYI: string literals do not have limits (neither 80, nor 100).
It's a special category.

-- 
With Best Regards,
Andy Shevchenko