lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Dec 2020 19:24:16 +0100 From: Paolo Bonzini <pbonzini@...hat.com> To: Vitaly Kuznetsov <vkuznets@...hat.com>, Sean Christopherson <seanjc@...gle.com> Cc: Wanpeng Li <wanpengli@...cent.com>, Jim Mattson <jmattson@...gle.com>, Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org, linux-kernel@...r.kernel.org, Ben Gardon <bgardon@...gle.com>, Richard Herbert <rherbert@...patico.ca> Subject: Re: [PATCH 2/4] KVM: x86/mmu: Get root level from walkers when retrieving MMIO SPTE On 18/12/20 10:10, Vitaly Kuznetsov wrote: >> - int root = vcpu->arch.mmu->shadow_root_level; >> - int leaf; >> - int level; >> + int root, leaf, level; >> bool reserved = false; > Personal taste: I would've renamed 'root' to 'root_level' (to be > consistent with get_walk()/kvm_tdp_mmu_get_walk()) and 'level' to > e.g. 'l' as it's only being used as an interator ('i' would also do). Maybe agree on the former, not really on the latter. :) Paolo
Powered by blists - more mailing lists