linux-kernel - Re: [PATCH] KVM: x86: change in pv_eoi_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a22baa12-7f37-054d-646b-b6ca393e01f7@redhat.com>
Date:   Mon, 21 Dec 2020 19:30:37 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Stephen Zhang <stephenzhangzsd@...il.com>, seanjc@...gle.com,
        vkuznets@...hat.com, wanpengli@...cent.com, jmattson@...gle.com,
        joro@...tes.org, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, x86@...nel.org, hpa@...or.com
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86: change in pv_eoi_get_pending() to make code
 more readable

On 18/12/20 08:51, Stephen Zhang wrote:
> Signed-off-by: Stephen Zhang <stephenzhangzsd@...il.com>
> ---
>   arch/x86/kvm/lapic.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> index 3136e05..7882322 100644
> --- a/arch/x86/kvm/lapic.c
> +++ b/arch/x86/kvm/lapic.c
> @@ -674,7 +674,7 @@ static bool pv_eoi_get_pending(struct kvm_vcpu *vcpu)
>   			   (unsigned long long)vcpu->arch.pv_eoi.msr_val);
>   		return false;
>   	}
> -	return val & 0x1;
> +	return val & KVM_PV_EOI_ENABLED;
>   }
>   
>   static void pv_eoi_set_pending(struct kvm_vcpu *vcpu)
> 

Queued, thanks.

Paolo