linux-kernel - Re: [PATCH v5 2/3] spi: Add SPI_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VftBQEK10Z7pkD18fpr8B7ipCXUXVx=1Hnuq-2w=z2hgQ@mail.gmail.com>
Date:   Mon, 21 Dec 2020 16:36:42 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     linux-spi <linux-spi@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Bogdan, Dragos" <dragos.bogdan@...log.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v5 2/3] spi: Add SPI_NO_TX/RX support

On Mon, Dec 21, 2020 at 4:34 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Mon, Dec 21, 2020 at 4:15 PM Alexandru Ardelean
> <alexandru.ardelean@...log.com> wrote:
> >
> > From: Dragos Bogdan <dragos.bogdan@...log.com>
> >
> > Transmit/receive only is a valid SPI mode. For example, the MOSI/TX line
> > might be missing from an ADC while for a DAC the MISO/RX line may be
> > optional. This patch adds these two new modes: SPI_NO_TX and
> > SPI_NO_RX. This way, the drivers will be able to identify if any of
> > these two lines is missing and to adjust the transfers accordingly.
> >
> > Signed-off-by: Dragos Bogdan <dragos.bogdan@...log.com>
>
> Missed Co-developed-by: Alexandru ... ?
>
> Anyway, looks good to me,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

One nit, though...

> > -               "setup: can not select dual and quad at the same time\n");
> > +               "setup: can not select any two of dual, quad and no-rx/tx "
> > +               "at the same time\n");

Can we avoid splitting string literals which are assumed to be on one
line when printed?

-- 
With Best Regards,
Andy Shevchenko