linux-kernel - Re: [PATCH] driver: staging: count ashmem_range into SLAB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHRSSEwGHqQHRzyBUAyqVZk4azr8aeJ_Hgw=_XzaSkfTiVEBcg@mail.gmail.com>
Date:   Mon, 21 Dec 2020 10:57:57 -0800
From:   Todd Kjos <tkjos@...gle.com>
To:     Huangzhaoyang <huangzhaoyang@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <christian@...uner.io>,
        "open list:ANDROID DRIVERS" <devel@...verdev.osuosl.org>,
        Zhaoyang Huang <zhaoyang.huang@...soc.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Hridya Valsaraju <hridya@...gle.com>
Subject: Re: [PATCH] driver: staging: count ashmem_range into SLAB_RECLAIMBLE

+Hridya Valsaraju +Suren Baghdasaryan


On Thu, Dec 17, 2020 at 11:48 PM Huangzhaoyang <huangzhaoyang@...il.com> wrote:
>
> From: Zhaoyang Huang <zhaoyang.huang@...soc.com>
>
> Add SLAB_RECLAIM_ACCOUNT to ashmem_range cache since it has registered
> shrinker, which make memAvailable more presiced.
>
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@...soc.com>

Acked-by: Todd Kjos <tkjos@...gle.com>

> ---
>  drivers/staging/android/ashmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 74d497d..b79301f 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -893,7 +893,7 @@ static int __init ashmem_init(void)
>
>         ashmem_range_cachep = kmem_cache_create("ashmem_range_cache",
>                                                 sizeof(struct ashmem_range),
> -                                               0, 0, NULL);
> +                                               0, SLAB_RECLAIM_ACCOUNT, NULL);
>         if (!ashmem_range_cachep) {
>                 pr_err("failed to create slab cache\n");
>                 goto out_free1;
> --
> 1.9.1
>