lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Dec 2020 18:26:41 -0600 From: Bjorn Andersson <bjorn.andersson@...aro.org> To: "Peng Fan (OSS)" <peng.fan@....nxp.com> Cc: ohad@...ery.com, mathieu.poirier@...aro.org, o.rempel@...gutronix.de, shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com, linux-imx@....com, linux-remoteproc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, paul@...pouillou.net, matthias.bgg@...il.com, agross@...nel.org, patrice.chotard@...com, Peng Fan <peng.fan@....com> Subject: Re: [PATCH 3/8] remoteproc: imx_rproc: correct err message On Mon 21 Dec 04:06 CST 2020, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@....com> > > It is using devm_ioremap, so not devm_ioremap_resource. Correct > the error message and print out sa/size. > Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org> > Signed-off-by: Peng Fan <peng.fan@....com> > --- > > V4: > Drop the R-b tag > Follow Bjorn's comments, correct/update the err msg. > > drivers/remoteproc/imx_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 6603e00bb6f4..fab772b02c9f 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, > att->sa, att->size); > if (!priv->mem[b].cpu_addr) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa); > return -ENOMEM; > } > priv->mem[b].sys_addr = att->sa; > @@ -298,7 +298,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > > priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res); > if (IS_ERR(priv->mem[b].cpu_addr)) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "failed to remap %pr\n", &res); > err = PTR_ERR(priv->mem[b].cpu_addr); > return err; > } > -- > 2.28.0 >
Powered by blists - more mailing lists