linux-kernel - Re: [PATCH v10 3/3] arm64: dts: sparx5: Add SGPIO devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87eejip2xm.fsf@microchip.com>
Date:   Tue, 22 Dec 2020 11:09:41 +0100
From:   Lars Povlsen <lars.povlsen@...rochip.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Lars Povlsen <lars.povlsen@...rochip.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        <devicetree@...r.kernel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        <linux-kernel@...r.kernel.org>,
        "Microchip Linux Driver Support" <UNGLinuxDriver@...rochip.com>,
        <linux-gpio@...r.kernel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v10 3/3] arm64: dts: sparx5: Add SGPIO devices


Andrew Lunn writes:

> On Fri, Nov 13, 2020 at 03:51:51PM +0100, Lars Povlsen wrote:
>> +             led@8 {
>> +                     label = "eth12:green";
>> +                     gpios = <&sgpio_out0 12 0 GPIO_ACTIVE_HIGH>;
>> +                     default-state = "off";
>> +             };
>> +             led@9 {
>> +                     label = "eth12:yellow";
>> +                     gpios = <&sgpio_out0 12 1 GPIO_ACTIVE_HIGH>;
>> +                     default-state = "off";
>> +             };
>
> Hi Lars
>
> I did not see these patches earlier, but i've been looking at the
> switch driver patches recently, so went digging.
>
> Can the Ethernet switch itself control these LEDs for indicating
> things like packet receive/transmit, link state, and link speed? Or
> are they purely software controlled?
>
>     Thanks
>         Andrew

Hi Andrew!

No, the SGPIO device is separate from the switch device as such. I was
planning to couple the two by means of "led events" in a later patch.

---Lars

--
Lars Povlsen,
Microchip