[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <66348e3c157ef48485f07d4b4043f01f@codeaurora.org>
Date: Tue, 22 Dec 2020 19:33:18 +0800
From: Can Guo <cang@...eaurora.org>
To: Stanley Chu <stanley.chu@...iatek.com>
Cc: linux-scsi@...r.kernel.org, martin.petersen@...cle.com,
avri.altman@....com, alim.akhtar@...sung.com, jejb@...ux.ibm.com,
beanhuo@...ron.com, asutoshd@...eaurora.org,
matthias.bgg@...il.com, bvanassche@....org,
linux-mediatek@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
kuohong.wang@...iatek.com, peter.wang@...iatek.com,
chun-hung.wu@...iatek.com, andy.teng@...iatek.com,
chaotian.jing@...iatek.com, cc.chou@...iatek.com,
jiajie.hao@...iatek.com, alice.chao@...iatek.com
Subject: Re: [PATCH v2 1/2] scsi: ufs: Fix possible power drain during system
suspend
On 2020-12-22 15:29, Stanley Chu wrote:
> Currently if device needs to do flush or BKOP operations,
> the device VCC power is kept during runtime-suspend period.
>
> However, if system suspend is happening while device is
> runtime-suspended, such power may not be disabled successfully.
>
> The reasons may be,
>
> 1. If current PM level is the same as SPM level, device will
> keep runtime-suspended by ufshcd_system_suspend().
>
> 2. Flush recheck work may not be scheduled successfully
> during system suspend period. If it can wake up the system,
> this is also not the intention of the recheck work.
>
> To fix this issue, simply runtime-resume the device if the flush
> is allowed during runtime suspend period. Flush capability will be
> disabled while leaving runtime suspend, and also not be allowed in
> system suspend period.
>
> Fixes: 51dd905bd2f6 ("scsi: ufs: Fix WriteBooster flush during runtime
> suspend")
> Reviewed-by: Chaotian Jing <chaotian.jing@...iatek.com>
> Signed-off-by: Stanley Chu <stanley.chu@...iatek.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index e221add25a7e..9d61dc3eb842 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -8903,7 +8903,8 @@ int ufshcd_system_suspend(struct ufs_hba *hba)
> if ((ufs_get_pm_lvl_to_dev_pwr_mode(hba->spm_lvl) ==
> hba->curr_dev_pwr_mode) &&
> (ufs_get_pm_lvl_to_link_pwr_state(hba->spm_lvl) ==
> - hba->uic_link_state))
> + hba->uic_link_state) &&
> + !hba->dev_info.b_rpm_dev_flush_capable)
> goto out;
>
> if (pm_runtime_suspended(hba->dev)) {
Reviewed-by: Can Guo <cang@...eaurora.org>
Powered by blists - more mailing lists