linux-kernel - Re: [PATCH] Bluetooth: btusb: Remove duplicate newlines from logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <81334976-F36B-42B9-8687-4D03E394E657@holtmann.org>
Date:   Tue, 22 Dec 2020 13:23:45 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Bluetooth: btusb: Remove duplicate newlines from logging

Hi Joe,

> The bt_dev_<level> macros already append a newline.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
> 
> The "No memory" message could be removed as bt_skb_alloc already does
> a dump_stack() on allocation failure.
> 
> drivers/bluetooth/btusb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel