linux-kernel - Re: [PATCH] drm/hisilicon: Remove drm_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Dec 2020 13:34:22 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Tian Tao <tiantao6@...ilicon.com>
Cc:     Dave Airlie <airlied@...ux.ie>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Gerd Hoffmann <kraxel@...hat.com>,
        Alex Deucher <alexander.deucher@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/hisilicon: Remove drm_dev_put in hibmc

On Tue, Dec 22, 2020 at 12:56 PM Tian Tao <tiantao6@...ilicon.com> wrote:
>
> Hibmc use the devm_drm_dev_alloc function in hibmc_pci_probe, if
> hibmc_pci_probe returns non-zero, devm_drm_dev_alloc will call
> devm_drm_dev_init, which will call devm_drm_dev_init_release to
> release drm_dev_put. There is no need for hibmc to call
> drm_dev_put separately.
>
> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>

lgtm, Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>

Cheers, Daniel
> ---
>  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> index 7159018..0d4e902 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> @@ -332,13 +332,13 @@ static int hibmc_pci_probe(struct pci_dev *pdev,
>         ret = pcim_enable_device(pdev);
>         if (ret) {
>                 drm_err(dev, "failed to enable pci device: %d\n", ret);
> -               goto err_free;
> +               goto err_return;
>         }
>
>         ret = hibmc_load(dev);
>         if (ret) {
>                 drm_err(dev, "failed to load hibmc: %d\n", ret);
> -               goto err_free;
> +               goto err_return;
>         }
>
>         ret = drm_dev_register(dev, 0);
> @@ -354,9 +354,7 @@ static int hibmc_pci_probe(struct pci_dev *pdev,
>
>  err_unload:
>         hibmc_unload(dev);
> -err_free:
> -       drm_dev_put(dev);
> -
> +err_return:
>         return ret;
>  }
>
> --
> 2.7.4
>


-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch