linux-kernel - Re: [PATCH v5 1/2] lib/string.c: add __sysfs_match_string_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+U=Dsr3agzr1jMPex7xxyPcyBGdw3tZNOqUQoeMJVkG+WutOw@mail.gmail.com>
Date:   Tue, 22 Dec 2020 15:00:02 +0200
From:   Alexandru Ardelean <ardeleanalex@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Alexandru Ardelean <alexandru.ardelean@...log.com>,
        linux-iio <linux-iio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        akpm@...ux-foundation.org,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v5 1/2] lib/string.c: add __sysfs_match_string_with_gaps() helper

On Tue, Dec 22, 2020 at 1:13 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Tue, Dec 22, 2020 at 11:52:09AM +0200, Alexandru Ardelean wrote:
> > The original docstring of the __sysfs_match_string() and match_string()
> > helper, implied that -1 could be used to search through NULL terminated
> > arrays, and positive 'n' can be used to go through arrays that may have
> > NULL elements in the middle of the array.
> >
> > This isn't true. Regardless of the value of 'n', the first NULL element in
> > the array.
>
> I can not parse this last sentence, is it missing something?

oh, my bad;
will fix this and send a new version

>
> thanks,
>
> greg k-h