linux-kernel - Re: [PATCH v2] nvmet: fix mismatched serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201222135059.GA32569@lst.de>
Date:   Tue, 22 Dec 2020 14:50:59 +0100
From:   Christoph Hellwig <hch@....de>
To:     zhenwei pi <pizhenwei@...edance.com>
Cc:     hch@....de, sagi@...mberg.me, chaitanya.kulkarni@....com,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2] nvmet: fix mismatched serial

On Sat, Dec 12, 2020 at 03:58:01PM +0800, zhenwei pi wrote:
> Target side uses 'bin2hex' to convert u64 serial number to a hex
> string, saving serial number as be64 to keep the right byte order.
> Also use format '%016llx' to show the full serial string to avoid
> to drop prefixed zero.
> 
> Test on x86 server, config '0123456789abcdef' to 'attr_serial' on
> target side, and run 'nvme id-ctrl /dev/nvme0' on initiator side,
> then we can get the same SN string.

We can't change this interface any more, as it can break tons of user
space.