linux-kernel - Re: [PATCH v3 18/24] wfx: add data_tx.c/data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878s9p97yp.fsf@codeaurora.org>
Date:   Tue, 22 Dec 2020 17:27:42 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Jerome Pouiller <Jerome.Pouiller@...abs.com>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S . Miller" <davem@...emloft.net>,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        linux-mmc@...r.kernel.org,
        Pali Rohár <pali@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH v3 18/24] wfx: add data_tx.c/data_tx.h

Jerome Pouiller <Jerome.Pouiller@...abs.com> writes:

> +static bool ieee80211_is_action_back(struct ieee80211_hdr *hdr)
> +{
> +	struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)hdr;
> +
> +	if (!ieee80211_is_action(mgmt->frame_control))
> +		return false;
> +	if (mgmt->u.action.category != WLAN_CATEGORY_BACK)
> +		return false;
> +	return true;
> +}

Don't use ieee80211_ prefix within a driver, it's reserved for mac80211.
Use wfx_ instead.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches