[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87a6u57smy.fsf@codeaurora.org>
Date: Tue, 22 Dec 2020 17:44:05 +0200
From: Kalle Valo <kvalo@...eaurora.org>
To: Jerome Pouiller <Jerome.Pouiller@...abs.com>
Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"David S . Miller" <davem@...emloft.net>,
devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
linux-mmc@...r.kernel.org,
Pali Rohár <pali@...nel.org>,
Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH v3 05/24] wfx: add main.c/main.h
Jerome Pouiller <Jerome.Pouiller@...abs.com> writes:
> +/* NOTE: wfx_send_pds() destroy buf */
> +int wfx_send_pds(struct wfx_dev *wdev, u8 *buf, size_t len)
> +{
> + int ret;
> + int start, brace_level, i;
> +
> + start = 0;
> + brace_level = 0;
> + if (buf[0] != '{') {
> + dev_err(wdev->dev, "valid PDS start with '{'. Did you forget to
> compress it?\n");
> + return -EINVAL;
> + }
> + for (i = 1; i < len - 1; i++) {
> + if (buf[i] == '{')
> + brace_level++;
> + if (buf[i] == '}')
> + brace_level--;
> + if (buf[i] == '}' && !brace_level) {
> + i++;
> + if (i - start + 1 > WFX_PDS_MAX_SIZE)
> + return -EFBIG;
> + buf[start] = '{';
> + buf[i] = 0;
> + dev_dbg(wdev->dev, "send PDS '%s}'\n", buf + start);
> + buf[i] = '}';
> + ret = hif_configuration(wdev, buf + start,
> + i - start + 1);
> + if (ret > 0) {
> + dev_err(wdev->dev, "PDS bytes %d to %d: invalid data (unsupported
> options?)\n",
> + start, i);
> + return -EINVAL;
> + }
> + if (ret == -ETIMEDOUT) {
> + dev_err(wdev->dev, "PDS bytes %d to %d: chip didn't reply (corrupted
> file?)\n",
> + start, i);
> + return ret;
> + }
> + if (ret) {
> + dev_err(wdev->dev, "PDS bytes %d to %d: chip returned an unknown
> error\n",
> + start, i);
> + return -EIO;
> + }
> + buf[i] = ',';
> + start = i;
> + }
> + }
> + return 0;
> +}
What does this function do? Looks very strange.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists