linux-kernel - Re: [RFC PATCH 4/4] powerpc: Use common of_kexec_setup_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbe0f26e-decd-a158-8787-9853a4ca7a6b@linux.microsoft.com>
Date:   Tue, 22 Dec 2020 15:33:12 -0800
From:   Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>
To:     Thiago Jung Bauermann <bauerman@...ux.ibm.com>,
        Rob Herring <robh@...nel.org>
Cc:     takahiro.akashi@...aro.org, will@...nel.org,
        catalin.marinas@....com, mpe@...erman.id.au, zohar@...ux.ibm.com,
        james.morse@....com, sashal@...nel.org, benh@...nel.crashing.org,
        paulus@...ba.org, frowand.list@...il.com,
        vincenzo.frascino@....com, mark.rutland@....com,
        dmitry.kasatkin@...il.com, jmorris@...ei.org, serge@...lyn.com,
        pasha.tatashin@...een.com, allison@...utok.net,
        masahiroy@...nel.org, bhsharma@...hat.com, mbrugger@...e.com,
        hsinyi@...omium.org, tao.li@...o.com, christophe.leroy@....fr,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        prsriva@...ux.microsoft.com, balajib@...ux.microsoft.com
Subject: Re: [RFC PATCH 4/4] powerpc: Use common of_kexec_setup_new_fdt()

On 12/22/20 1:55 PM, Thiago Jung Bauermann wrote:
> 
> Rob Herring <robh@...nel.org> writes:
> 
>> Signed-off-by: Rob Herring <robh@...nel.org>
>> ---
>>
>> After the IMA changes, delete_fdt_mem_rsv() can also be removed.
>>
>>   arch/powerpc/kexec/file_load.c | 125 ++-------------------------------
>>   1 file changed, 6 insertions(+), 119 deletions(-)
> 
> Reviewed-by: Thiago Jung Bauermann <bauerman@...ux.ibm.com>
> 
> Shouldn't this series also be Cc'd to the linuxppc-dev mailing list?
> 
> I just noticed that the ARM64 IMA kexec series hasn't been copying the
> linuxppc-dev mailing list, so perhaps this is why this series isn't
> doing that, either.

Thanks for pointing that out Thiago.
I will copy linuxppc-dev mailing list (linuxppc-dev@...r.kernel.org) 
when I post v14 of my patch set.

  -lakshmi

> 
>> diff --git a/arch/powerpc/kexec/file_load.c b/arch/powerpc/kexec/file_load.c
>> index e452b11df631..956bcb2d1ec2 100644
>> --- a/arch/powerpc/kexec/file_load.c
>> +++ b/arch/powerpc/kexec/file_load.c
>> @@ -16,6 +16,7 @@
>>
>>   #include <linux/slab.h>
>>   #include <linux/kexec.h>
>> +#include <linux/of.h>
>>   #include <linux/of_fdt.h>
>>   #include <linux/libfdt.h>
>>   #include <asm/setup.h>
> 
> It's possible to remove the <linux/of_fdt.h> include now.
>