[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAL_JsqJLw_RtLehYDLu_HKCoxDHsx-AdGTWfN0JMJhgNqLeFng@mail.gmail.com>
Date: Wed, 23 Dec 2020 10:54:26 -0700
From: Rob Herring <robh@...nel.org>
To: Sam Ravnborg <sam@...nborg.org>
Cc: devicetree@...r.kernel.org,
Linux-ALSA <alsa-devel@...a-project.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Linux USB List <linux-usb@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
dri-devel <dri-devel@...ts.freedesktop.org>,
Jassi Brar <jaswinder.singh@...aro.org>,
Vinod Koul <vkoul@...nel.org>, Mark Brown <broonie@...nel.org>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
"open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM"
<dmaengine@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: Drop redundant maxItems/items
On Mon, Dec 21, 2020 at 11:39 PM Sam Ravnborg <sam@...nborg.org> wrote:
>
> Hi Rob,
>
> On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> > preferred for a single entry while greater than 1 should have an 'items'
> > list.
> >
> > A meta-schema check for this is pending once these existing cases are
> > fixed.
> >
> > Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > Cc: Vinod Koul <vkoul@...nel.org>
> > Cc: Mark Brown <broonie@...nel.org>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: Jassi Brar <jaswinder.singh@...aro.org>
> > Cc: dri-devel@...ts.freedesktop.org
> > Cc: dmaengine@...r.kernel.org
> > Cc: alsa-devel@...a-project.org
> > Cc: linux-usb@...r.kernel.org
> > Signed-off-by: Rob Herring <robh@...nel.org>
>
> With one comment below,
> Acked-by: Sam Ravnborg <sam@...nborg.org>
>
> > ---
> > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > index 737c1f47b7de..54c361d4a7af 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > @@ -74,11 +74,8 @@ properties:
> >
> > phys:
> > maxItems: 1
> > - items:
> > - - description: phandle + phy specifier pair.
>
> The description may help some people, so keeping the
> description and deleting maxItems would maybe be better.
Do we really want to describe 'phys' hundreds of times? No. The
question I ask on the descriptions is could it be generated instead.
Rob
Powered by blists - more mailing lists