linux-kernel - Re: [PATCH] proc/wchan: Use printk format instead of lookup_symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201223122942.3650e2fdf74c6e8f0a982010@linux-foundation.org>
Date:   Wed, 23 Dec 2020 12:29:42 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Helge Deller <deller@....de>
Cc:     Alexey Dobriyan <adobriyan@...il.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] proc/wchan: Use printk format instead of
 lookup_symbol_name()

On Wed, 23 Dec 2020 10:48:10 +0100 Helge Deller <deller@....de> wrote:

> >  static int proc_pid_wchan(struct seq_file *m, struct pid_namespace *ns,
> >  			  struct pid *pid, struct task_struct *task)
> >  {
> > -	unsigned long wchan;
> > -
> >  	if (ptrace_may_access(task, PTRACE_MODE_READ_FSCREDS))
> > -		wchan = get_wchan(task);
> > -	else
> > -		wchan = 0;
> > -
> > -	if (wchan)
> > -		seq_printf(m, "%ps", (void *) wchan);
> > +		seq_printf(m, "%ps", (void *)get_wchan(task));
> >  	else
> >  		seq_putc(m, '0');
> 
> get_wchan() does return NULL sometimes, in which case with
> your change now "0x0" instead of "0" gets printed.

Ah, OK, ignore ;)