lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 23 Dec 2020 12:37:47 -0800
From:   Jakub Kicinski <>
To:     Dinghao Liu <>
Cc:, Christian Benvenuti <>,
        Govindarajulu Varadarajan <>,
        "David S. Miller" <>,,
Subject: Re: [PATCH] enic: Remove redundant free in enic_set_ringparam

On Wed, 23 Dec 2020 20:38:33 +0800 Dinghao Liu wrote:
> The error handling paths in enic_alloc_vnic_resources()
> have called enic_free_vnic_resources() before returning.
> So we may not need to call it again on failure at caller
> side.
> Signed-off-by: Dinghao Liu <>

But it's harmless, right? So the patch is just a cleanup not a fix?

In that case, could you please repost in two weeks? We're currently 
in the merge window period, we're only accepting fixes to the
networking trees.


Powered by blists - more mailing lists