lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Dec 2020 22:24:03 +0000 From: Daniel Scally <djrscally@...il.com> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Sakari Ailus <sakari.ailus@...ux.intel.com> Cc: linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org, linux-media@...r.kernel.org, devel@...ica.org, rjw@...ysocki.net, lenb@...nel.org, gregkh@...uxfoundation.org, yong.zhi@...el.com, bingbu.cao@...el.com, tian.shu.qiu@...el.com, mchehab@...nel.org, robert.moore@...el.com, erik.kaneda@...el.com, pmladek@...e.com, rostedt@...dmis.org, sergey.senozhatsky@...il.com, linux@...musvillemoes.dk, laurent.pinchart+renesas@...asonboard.com, jacopo+renesas@...ndi.org, kieran.bingham+renesas@...asonboard.com, linus.walleij@...aro.org, heikki.krogerus@...ux.intel.com, kitakar@...il.com, jorhand@...ux.microsoft.com, kernel test robot <lkp@...el.com>, Dan Carpenter <dan.carpenter@...cle.com>, Laurent Pinchart <laurent.pinchart@...asonboard.com> Subject: Re: [PATCH v2 05/12] software_node: unregister software_nodes in reverse order On 21/12/2020 11:26, Andy Shevchenko wrote: > On Mon, Dec 21, 2020 at 11:21:16AM +0200, Sakari Ailus wrote: >> On Thu, Dec 17, 2020 at 11:43:30PM +0000, Daniel Scally wrote: >>> To maintain consistency with software_node_unregister_nodes(), reverse >>> the order in which the software_node_unregister_node_group() function >>> unregisters nodes. > > ... > >>> void software_node_unregister_node_group(const struct software_node **node_group) >>> { >>> - unsigned int i; >>> + unsigned int i = 0; >>> >>> if (!node_group) >>> return; >>> >>> - for (i = 0; node_group[i]; i++) >>> + while (node_group[i]->name) >> >> Why is this change made? node_group is a NULL-terminated array, and the >> above accesses the name pointer on each entry before checking the entry is >> non-NULL. Or do I miss something here? > > I believe it's a copy'n'paste typo. Careless copy and paste yeah, my bad. I was doing it for consistency but really should've just changed the ordering; I'll just drop that part.
Powered by blists - more mailing lists