lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Dec 2020 21:48:02 -0300 From: Thiago Jung Bauermann <bauerman@...ux.ibm.com> To: Lakshmi Ramasubramanian <nramas@...ux.microsoft.com> Cc: zohar@...ux.ibm.com, robh@...nel.org, takahiro.akashi@...aro.org, gregkh@...uxfoundation.org, will@...nel.org, catalin.marinas@....com, mpe@...erman.id.au, james.morse@....com, sashal@...nel.org, benh@...nel.crashing.org, paulus@...ba.org, frowand.list@...il.com, vincenzo.frascino@....com, mark.rutland@....com, dmitry.kasatkin@...il.com, jmorris@...ei.org, serge@...lyn.com, pasha.tatashin@...een.com, allison@...utok.net, masahiroy@...nel.org, bhsharma@...hat.com, mbrugger@...e.com, hsinyi@...omium.org, tao.li@...o.com, christophe.leroy@....fr, prsriva@...ux.microsoft.com, balajib@...ux.microsoft.com, linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org Subject: Re: [PATCH v13 2/6] powerpc: Move arch independent ima kexec functions to drivers/of/kexec.c Actually, I have one more comment on this patch: Lakshmi Ramasubramanian <nramas@...ux.microsoft.com> writes: > diff --git a/arch/powerpc/kexec/file_load.c b/arch/powerpc/kexec/file_load.c > index 956bcb2d1ec2..9f3ec0b239ef 100644 > --- a/arch/powerpc/kexec/file_load.c > +++ b/arch/powerpc/kexec/file_load.c > @@ -20,7 +20,6 @@ > #include <linux/of_fdt.h> > #include <linux/libfdt.h> > #include <asm/setup.h> > -#include <asm/ima.h> > > #define SLAVE_CODE_SIZE 256 /* First 0x100 bytes */ > > @@ -163,12 +162,6 @@ int setup_new_fdt(const struct kimage *image, void *fdt, > if (ret) > goto err; > > - ret = setup_ima_buffer(image, fdt, fdt_path_offset(fdt, "/chosen")); > - if (ret) { > - pr_err("Error setting up the new device tree.\n"); > - return ret; > - } > - > return 0; > > err: With this change, setup_new_fdt() is nothing more than a call to of_kexec_setup_new_fdt(). It should be removed, and its caller should call of_kexec_setup_new_fdt() directly. This change could be done in patch 4 of this series, to keep this patch simpler. -- Thiago Jung Bauermann IBM Linux Technology Center
Powered by blists - more mailing lists