linux-kernel - Re: [PATCH phy] PHY: Ingenic: fix unconditional build of phy-ingenic-usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b34319d-b085-853a-c2f8-384bd60f50ff@wanyeetech.com>
Date:   Wed, 23 Dec 2020 22:18:07 +0800
From:   Zhou Yanjie <zhouyanjie@...yeetech.com>
To:     Alexander Lobakin <alobakin@...me>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>
Cc:     漆鹏振 <aric.pzqi@...enic.com>,
        Paul Cercueil <paul@...pouillou.net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH phy] PHY: Ingenic: fix unconditional build of
 phy-ingenic-usb

Hi Alexander,

On 2020/12/22 下午9:10, Alexander Lobakin wrote:
> Currently drivers/phy/ingenic/Makefile adds phy-ingenic-usb to targets
> not depending on actual Kconfig symbol CONFIG_PHY_INGENIC_USB, so this
> driver always gets built[-in] on every system.
> Add missing dependency.
>
> Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic PHY framework.")
> Signed-off-by: Alexander Lobakin <alobakin@...me>
> ---
>   drivers/phy/ingenic/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)


Apologize for my carelessness, and

Tested-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>


Thanks and best regards!


> diff --git a/drivers/phy/ingenic/Makefile b/drivers/phy/ingenic/Makefile
> index 65d5ea00fc9d..1cb158d7233f 100644
> --- a/drivers/phy/ingenic/Makefile
> +++ b/drivers/phy/ingenic/Makefile
> @@ -1,2 +1,2 @@
>   # SPDX-License-Identifier: GPL-2.0
> -obj-y		+= phy-ingenic-usb.o
> +obj-$(CONFIG_PHY_INGENIC_USB)		+= phy-ingenic-usb.o