linux-kernel - Re: [PATCH v7 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Dec 2020 11:50:02 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        marek.vasut+renesas@...il.com, lee.jones@...aro.org,
        matti.vaittinen@...rohmeurope.com, lgirdwood@...il.com,
        broonie@...nel.org, linus.walleij@...aro.org,
        bgolaszewski@...libre.com
Cc:     khiem.nguyen.xt@...esas.com, linux-power@...rohmeurope.com,
        linux-gpio@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

Hello!

On 24.12.2020 10:04, Yoshihiro Shimoda wrote:

> Use dev_regmap_add_irq_chip() to simplify the code.

    devm_?

> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>
> Reviewed-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>   drivers/mfd/bd9571mwv.c | 27 ++++++---------------------
>   1 file changed, 6 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/mfd/bd9571mwv.c b/drivers/mfd/bd9571mwv.c
> index e68c3fa..49e968e 100644
> --- a/drivers/mfd/bd9571mwv.c
> +++ b/drivers/mfd/bd9571mwv.c
> @@ -170,31 +170,17 @@ static int bd9571mwv_probe(struct i2c_client *client,
>   	if (ret)
>   		return ret;
>   
> -	ret = regmap_add_irq_chip(bd->regmap, bd->irq, IRQF_ONESHOT, 0,
> -				  &bd9571mwv_irq_chip, &bd->irq_data);
> +	ret = devm_regmap_add_irq_chip(bd->dev, bd->regmap, bd->irq,
> +				       IRQF_ONESHOT, 0, &bd9571mwv_irq_chip,
> +				       &bd->irq_data);
>   	if (ret) {
>   		dev_err(bd->dev, "Failed to register IRQ chip\n");
>   		return ret;
>   	}
>   
[...]

MBR, Sergei