linux-kernel - Re: [PATCH] arm64/smp: Remove unused irq variable in arch_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12e192f7-cef5-5dc1-32e4-75a97e77e9c6@huawei.com>
Date:   Fri, 25 Dec 2020 15:05:28 +0800
From:   Zenghui Yu <yuzenghui@...wei.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>
CC:     Gavin Shan <gshan@...hat.com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <wanghaibin.wang@...wei.com>
Subject: Re: [PATCH] arm64/smp: Remove unused irq variable in
 arch_show_interrupts()

On 2020/12/15 18:30, Geert Uytterhoeven wrote:
>      arch/arm64/kernel/smp.c: In function ‘arch_show_interrupts’:
>      arch/arm64/kernel/smp.c:808:16: warning: unused variable ‘irq’ [-Wunused-variable]
>        808 |   unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
> 	  |                ^~~
> 
> The removal of the last user forgot to remove the variable.
> 
> Fixes: 2f516e34383d0e97 ("arm64/smp: Use irq_desc_kstat_cpu() in arch_show_interrupts()")

This is in mainline now and the commit id is 5089bc51f81f.

> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> One more issue in irq-core-2020-12-14.
> 
>   arch/arm64/kernel/smp.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index 3aef3bc22d3250b5..10b39328268687e3 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -805,7 +805,6 @@ int arch_show_interrupts(struct seq_file *p, int prec)
>   	unsigned int cpu, i;
>   
>   	for (i = 0; i < NR_IPI; i++) {
> -		unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
>   		seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i,
>   			   prec >= 4 ? " " : "");
>   		for_each_online_cpu(cpu)

And I guess we have the same problem on 32-bit ARM. 'irq' in
show_ipi_list() is no longer used since commit 88c637748e31
("ARM: smp: Use irq_desc_kstat_cpu() in show_ipi_list()").


Thanks,
Zenghui