lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 25 Dec 2020 16:13:34 +0800
From:   Defang Bo <>
        Defang Bo <>
Subject: [PATCH 2/2] drivers/gpu/drm/ast: Fix infinite loop if read fails

[Why] Similar to commit <298360af3> ast_init_dram_reg() configures a window in order to access BMC memory.
A BMC register can be configured to disallow this, and if so, causes
an infinite loop in the ast driver which renders the system unusable.
Fix this by erroring out if an error is detected.

Signed-off-by: Defang Bo <>
 drivers/gpu/drm/ast/ast_post.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/ast/ast_post.c b/drivers/gpu/drm/ast/ast_post.c
index ef19c70..86e4d23 100644
--- a/drivers/gpu/drm/ast/ast_post.c
+++ b/drivers/gpu/drm/ast/ast_post.c
@@ -302,13 +302,13 @@ static void ast_init_dram_reg(struct drm_device *dev)
 			ast_write32(ast, 0x12000, 0x1688A8A8);
 			do {
 				if (pci_channel_offline(dev->pdev))
-                                        return -EIO;
+					return -EIO;
 			} while (ast_read32(ast, 0x12000) != 0x01);
 			ast_write32(ast, 0x10000, 0xfc600309);
 			do {
 				if (pci_channel_offline(dev->pdev))
-                                        return -EIO;
+					return -EIO;
 			} while (ast_read32(ast, 0x10000) != 0x01);

Powered by blists - more mailing lists