lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 26 Dec 2020 10:51:09 +0800 From: Lai Jiangshan <jiangshanlai@...il.com> To: linux-kernel@...r.kernel.org Cc: Valentin Schneider <valentin.schneider@....com>, Peter Zijlstra <peterz@...radead.org>, Qian Cai <cai@...hat.com>, Vincent Donnefort <vincent.donnefort@....com>, Dexuan Cui <decui@...rosoft.com>, Lai Jiangshan <laijs@...ux.alibaba.com>, Tejun Heo <tj@...nel.org>, Lai Jiangshan <jiangshanlai@...il.com>, Daniel Bristot de Oliveira <bristot@...hat.com> Subject: [PATCH -tip V3 1/8] workqueue: use cpu_possible_mask instead of cpu_active_mask to break affinity From: Lai Jiangshan <laijs@...ux.alibaba.com> The scheduler won't break affinity for us any more, and we should "emulate" the same behavior when the scheduler breaks affinity for us. The behavior is "changing the cpumask to cpu_possible_mask". And there might be some other CPUs online later while the worker is still running with the pending work items. The worker should be allowed to use the later online CPUs as before and process the work items ASAP. If we use cpu_active_mask here, we can't achieve this goal but using cpu_possible_mask can. Fixes: 06249738a41a ("workqueue: Manually break affinity on hotplug") Acked-by: Tejun Heo <tj@...nel.org> Signed-off-by: Lai Jiangshan <laijs@...ux.alibaba.com> --- kernel/workqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index c71da2a59e12..f2b8f3d458d1 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -4910,7 +4910,7 @@ static void unbind_workers(int cpu) raw_spin_unlock_irq(&pool->lock); for_each_pool_worker(worker, pool) - WARN_ON_ONCE(set_cpus_allowed_ptr(worker->task, cpu_active_mask) < 0); + WARN_ON_ONCE(set_cpus_allowed_ptr(worker->task, cpu_possible_mask) < 0); mutex_unlock(&wq_pool_attach_mutex); -- 2.19.1.6.gb485710b
Powered by blists - more mailing lists